3.3 KiB
Minutes from 34th OpenVDB TSC meeting, November 28, 2019, (GMT)
Attendees: Nick A., Dan B., Jeff L., Ken M.
Regrets: Peter C.
Agenda:
-
Confirm quorum
-
Secretary
-
OVDB 117: Nondeterministic Meshing
-
PR Change for leaky mesh.
-
Strange CI Failures?
-
CMake PR from David
-
Release plan for 7.0
-
Curvature methods and gaussian methods
-
Roadmap
-
PR 573: DSO changes
-
OVDB-33: Threadsafety of copy constructor.
-
Merged in Copyright Header changes.
-
PR 566: Update project license.
-
PR 561: Add child node request.
-
PR 493: POPCNT.
-
Spark FX conference BoF?
-
Next meeting
-
Quorum was confirmed.
-
Secretary was Jeff Lait
-
OVDB 117
This is the non deterministic mesh bug. This was a result of non-reentrancy of threadedlocal storage used for the scratch primitive tree. Introduced by clear() becoming threaded in 3.2. If the primitive id ends up being the sentinel value it doesn't reset and instead uses the background value.
Should clear remain multithreaded? Change how we assign the reset value? Or change the background value?
Parallel clear does make a difference, so it is justified to have a multithreaded clear(). But the scratch pad should never have got large in any case. And it is inside a parallel for in any case.
We should check for this pattern of thread local storage elsewhere.
PR will change to serial clear.
- PR Change for leaky mesh.
Nick will attempt to look at the code change.
- Strange CI Failures?
"Run Failed" from github when doing a pull request? Forward these errors to Dan.
- CMake PR from David
Needed separate PR request to do the final clean up. Can we directly edit the PR? This will cause it to persist in their repository. We should be courteous about it and alert them we plan on changing their PR. But we reserve the right to modify external users if they have enabled the switch.
We should add to our contribution guidelines that we may change your PR.
- Release plan for 7.0
Nick will do the release, with Dan providing a checklist.
- Curvature methods and gaussian methods
No changes in this PR to the SOP. Adds more curvature options. Likely will want to add more options to the analysis SOP.
Regarding the free standing functions that are removed. API of tools has been allowed to change. Add to the review if we should keep them.
Note the genus computation can become unstable.
- Roadmap
Should add a roadmap for the release. Start the discussion after 7.0 release.
- PR 573: DSO changes
Nick is to inspect.
- OVDB-33. Threadsafety of copy constructor.
Must be prioritized for 7.0. Nick to inspect.
- Merged in Copyright Header changes.
We should check for any existing copyrights owned by our respective companies. New files should use the copyright to contributors and SPDX
- PR 566: Update project license.
Update project license. Needs second review.
- PR 561: Add child node request.
Ken to review.
- PR 493: POPCNT.
Replaced with new PR which is incoming. Much of the original code was for the deprecated root node mask that is not worth optimizing, so the new PR is smaller.
- Spark FX conference BoF?
Artist tailored conference. Dan will follow up and see if he can attend.
- Next planned meeting is:
December 5th 2019. 2pm-3pm EST (GMT-5).